XWIKI-7342: Dependencies needed by the GWT compiler should never be triggered...

XWIKI-7342: Dependencies needed by the GWT compiler should never be triggered as transitive dependencies
* Made smartgwt a "provided" dependency

xwiki-platform-core/pom.xml

@@ -34,7 +34,6 @@
   <packaging>pom</packaging>
   <description>XWiki Platform - Core - Parent POM</description>
   <properties>
-    <!-- We use our custom version of GWT because some dependencies are missing from the gwt-user 2.3.0 POM. -->
     <gwt.version>2.4.0</gwt.version>
     <gwt.maven.plugin.version>2.4.0</gwt.maven.plugin.version>
     <smartgwt.version>3.0</smartgwt.version>
@@ -107,23 +106,22 @@
         <groupId>com.google.gwt</groupId>
         <artifactId>gwt-user</artifactId>
         <version>${gwt.version}</version>
+        <!-- Only needed at build time -->
+        <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>com.google.gwt</groupId>
         <artifactId>gwt-servlet</artifactId>
         <version>${gwt.version}</version>
       </dependency>
-      <dependency>
-        <groupId>com.google.gwt</groupId>
-        <artifactId>gwt-dev</artifactId>
-        <version>${gwt.version}</version>
-      </dependency>
       <dependency>
         <!-- SmartGWT is used only for its tree widget. -->
         <!-- If you remove or move this dependency don't forget to update the repository section at the bottom. -->
         <groupId>com.smartgwt</groupId>
         <artifactId>smartgwt</artifactId>
         <version>${smartgwt.version}</version>
+        <!-- Only needed at build time -->
+        <scope>provided</scope>
       </dependency>
     </dependencies>
   </dependencyManagement>
@@ -150,8 +148,9 @@
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>gwt-maven-plugin</artifactId>
           <version>${gwt.maven.plugin.version}</version>
-          <!-- We need to declare these dependencies because we use a newer version of GWT.
-            See http://mojo.codehaus.org/gwt-maven-plugin/user-guide/using-different-gwt-sdk-version.html -->
+          <!-- We declare these dependencies here in case we use different value for ${gwt.version} and
+               ${gwt.maven.plugin.version} variables.
+               See http://mojo.codehaus.org/gwt-maven-plugin/user-guide/using-different-gwt-sdk-version.html -->
           <dependencies>
             <dependency>
               <groupId>com.google.gwt</groupId>

xwiki-platform-core/xwiki-platform-gwt/pom.xml

@@ -43,8 +43,6 @@
     <dependency>
       <groupId>com.google.gwt</groupId>
       <artifactId>gwt-user</artifactId>
-      <!-- Only needed at build time -->
-      <scope>provided</scope>
     </dependency>
   </dependencies>
   <build>

xwiki-platform-core/xwiki-platform-gwt/xwiki-platform-gwt-api/pom.xml

@@ -36,12 +36,6 @@
       <groupId>com.google.gwt</groupId>
       <artifactId>gwt-servlet</artifactId>
     </dependency>
-    <dependency>
-      <groupId>com.google.gwt</groupId>
-      <artifactId>gwt-user</artifactId>
-      <!-- Overwrite the scope from the parent POM to prevent gwt-user jar from being included in the distribution war. -->
-      <scope>provided</scope>
-    </dependency>
     <dependency>
       <groupId>org.xwiki.platform</groupId>
       <artifactId>xwiki-platform-oldcore</artifactId>

xwiki-platform-core/xwiki-platform-gwt/xwiki-platform-gwt-dom/pom.xml

@@ -33,9 +33,10 @@
   <description>An extension of the GWT DOM API, providing W3C Range and Selection support, depth-first pre-order iterator and lots of DOM utility methods</description>
   <dependencies>
     <dependency>
-      <!-- This dependency is required for the custom linker. -->
+      <!-- This dependency is required for the custom linker (StandardsModeIFrameLinker.kava). -->
       <groupId>com.google.gwt</groupId>
       <artifactId>gwt-dev</artifactId>
+      <version>${gwt.version}</version>
       <!-- Only needed at build time -->
       <scope>provided</scope>
     </dependency>

xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client/pom.xml

@@ -36,8 +36,6 @@
     <dependency>
       <groupId>com.google.gwt</groupId>
       <artifactId>gwt-user</artifactId>
-      <!-- Only needed at build time -->
-      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.xwiki.platform</groupId>

xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-plugin-api/pom.xml

@@ -35,8 +35,6 @@
     <dependency>
       <groupId>com.google.gwt</groupId>
       <artifactId>gwt-user</artifactId>
-      <!-- Only needed at build time -->
-      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.xwiki.platform</groupId>

xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-war/pom.xml

@@ -51,6 +51,11 @@
       <artifactId>xwiki-platform-wysiwyg-server</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <!-- SmartGWT is used only for its tree widget. -->
+      <groupId>com.smartgwt</groupId>
+      <artifactId>smartgwt</artifactId>
+    </dependency>
   </dependencies>
   <build>
     <plugins>