XCOMMONS-891: Replace Maven CLIRR with a more modern solution that works on java8

xwiki-platform-core/pom.xml

@@ -527,6 +527,52 @@
           </excludes>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>com.github.siom79.japicmp</groupId>
+        <artifactId>japicmp-maven-plugin</artifactId>
+        <configuration>
+          <parameter>
+            <excludes combine.children="append">
+              <!-- Not really a breackage. Just moved to its own module. -->
+              <exclude>com.xpn.xwiki.plugin.diff.DiffPlugin</exclude>
+              <exclude>com.xpn.xwiki.plugin.diff.DiffPluginApi</exclude>
+              <!-- Removed constant that shouldn't have been there -->
+              <exclude>org.xwiki.chart.ChartGenerator</exclude>
+              <!-- Young API. Added searchFlavors() -->
+              <exclude>org.xwiki.platform.flavor.FlavorManager</exclude>
+            </excludes>
+          </parameter>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.revapi</groupId>
+        <artifactId>revapi-maven-plugin</artifactId>
+        <configuration>
+          <analysisConfiguration><![CDATA[
+            {
+              "revapi": {
+                "filter": {
+                  "elements": {
+                     "exclude": [".*\\.internal\\..*", ".*\\.test\\..*"]
+                  }
+                },
+                "ignore": [
+                  {
+                    "code": "java.field.removedWithConstant",
+                    "old": "field org.xwiki.chart.ChartGenerator.COLORS_PARAM",
+                    "justification": "Removed constant that shouldn't have been there"
+                  },
+                  {
+                    "code": "java.method.addedToInterface",
+                    "new": "method org.xwiki.extension.repository.result.IterableResult<org.xwiki.extension.Extension> org.xwiki.platform.flavor.FlavorManager::searchFlavors(org.xwiki.platform.flavor.FlavorQuery)",
+                    "justification": "Young API. Added searchFlavors()"
+                  }
+                ]
+              }
+            }
+          ]]></analysisConfiguration>
+        </configuration>
+      </plugin>
     </plugins>
     <extensions>
       <!-- Needed to add support for the "xar" packaging -->

xwiki-platform-core/xwiki-platform-diffplugin/pom.xml

@@ -32,6 +32,9 @@
   <description>Old diff plugin</description>
   <properties>
     <xwiki.jacoco.instructionRatio>0.80</xwiki.jacoco.instructionRatio>
+    <!-- Skip japicmp since there's no previous version of this module as it was introduced in 8.0M1.
+         TODO: Remove once we start comparing to 8.0 -->
+    <xwiki.japicmp.skip>true</xwiki.japicmp.skip>
   </properties>
   <dependencies>
     <dependency>
@@ -44,7 +47,6 @@
       <artifactId>xwiki-platform-oldcore</artifactId>
       <version>${project.version}</version>
     </dependency>
-
     <!-- Test dependencies -->
     <dependency>
       <groupId>org.jmock</groupId>

xwiki-platform-core/xwiki-platform-oldcore/pom.xml

@@ -36,6 +36,8 @@
     <xwiki.extension.features>com.xpn.xwiki.platform:xwiki-core</xwiki.extension.features>
     <!-- Skipping CLIRR since xwiki-platform-legacy-oldcore wraps this module and runs CLIRR on it -->
     <xwiki.clirr.skip>true</xwiki.clirr.skip>
+    <!-- Skipping revapi since xwiki-platform-legacy-oldcore wraps this module and runs revapi on it -->
+    <xwiki.revapi.skip>true</xwiki.revapi.skip>
     <xwiki.jacoco.instructionRatio>0.29</xwiki.jacoco.instructionRatio>
     <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
     <xwiki.surefire.captureconsole.skip>true</xwiki.surefire.captureconsole.skip>