XWIKI-18003: Pencil buttons on profile page are not consistent with the used...

XWIKI-18003: Pencil buttons on profile page are not consistent with the used icon theme and missing contrast (#1671)

* Add pencil icon in profile edit link
* Update profile edit link style

xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-ui/src/main/resources/Dashboard/XWikiUserDashboardSheet.xml

@@ -286,6 +286,7 @@
             <div class="editProfileCategory">
               <a title="$escapetool.xml($services.localization.render('platform.core.profile.category.dashboard.edit'))"
                   href="$doc.getURL('edit', 'category=dashboard')" class="btn btn-xs">
+                <span class="action-icon">$services.icon.renderHTML('pencil')</span>
                 <span class='sr-only'>$escapetool.xml($services.localization.render('platform.core.profile.category.dashboard.edit'))</span>
               </a>
             </div>

xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-ui/src/main/resources/XWiki/XWikiUserPreferencesSheet.xml

@@ -282,6 +282,7 @@
         <div class="editProfileCategory">
           <a title="$escapetool.xml($services.localization.render('platform.core.profile.category.preferences.edit'))"
               href="$doc.getURL('edit', 'category=preferences')" class="btn btn-xs">
+            <span class="action-icon">$services.icon.renderHTML('pencil')</span>
             <span class='sr-only'>$escapetool.xml($services.localization.render('platform.core.profile.category.preferences.edit'))</span>
           </a>
         </div>

xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-ui/src/main/resources/XWiki/XWikiUserProfileSheet.xml

@@ -568,8 +568,9 @@
     <div class='userInfo'>
     #if($xcontext.action == 'view' && $hasEdit)
       <div class='editProfileCategory'>
-        <a title="$escapetool.xml($services.localization.render('platform.core.profile.category.profile.edit'))" 
-              href="$doc.getURL('edit', 'editor=inline&category=profile')">
+        <a title="$escapetool.xml($services.localization.render('platform.core.profile.category.profile.edit'))"
+           href="$doc.getURL('edit', 'editor=inline&category=profile')" class="btn btn-xs">
+          <span class="action-icon">$services.icon.renderHTML('pencil')</span>
           <span class='sr-only'>$escapetool.xml($services.localization.render('platform.core.profile.category.profile.edit'))</span>
         </a>
       </div>

xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-ui/src/main/resources/XWiki/XWikiUserSheet.xml

@@ -568,6 +568,7 @@
 .userInfo h2 {
   font-size: larger;
   font-weight: bolder;
+  margin-top: 10px;
 }
         
 div.userInfo input[type="text"], div.userInfo input[type="password"], div.userInfo textarea, div.userInfo select, div.userPreferences select {
@@ -578,13 +579,22 @@
   float:right;
 }
 
-div.editProfileCategory a {
-  display:block;
-  width: 16px;
-  height: 16px;
-  background: url("$xwiki.getSkinFile('icons/silk/pencil.png')") no-repeat;
+div.editProfileCategory {
+  float:right;
+  a.btn-xs {
+    background-color: @xwiki-page-content-bg;
+    border: 1px solid @xwiki-border-color;
+    .action-icon {
+      font-size: larger;
+      color: @btn-default-color;
+    }
+    &:hover, &:active, &:focus {
+      border-color: darken(@dropdown-divider-bg, 10%);
+    }
+  }
 }
 
+
 /* Watchlist */
 
 #watchlistRssLink {
@@ -674,6 +684,9 @@
   clear: right;
 }</code>
     </property>
+    <property>
+      <contentType>LESS</contentType>
+    </property>
     <property>
       <name>userprofile</name>
     </property>