XWIKI-21988: Page naming strategy is blocking creation of pages not respecting it (#3229)
The goal here is to immediately display a feedback in the create page dialog telling the user that the reference is wrong before they click on create. I performed following changes here: * Refactor CreateActionRequestHandler to have a clean separation between retrieving the reference and performing checks over templates * Refactor a bit CreateAction to perform immediate checks over the rights and the name strategy before even checking if the template is chosen: the goal being here to immediately provide exception if there's a problem * Refactor createinline.vm to inject bootstrap modal html elements when used with an ajax request: the idea here is to display an ajax modal instead of the old deprecated xwiki dialog * Refactor xwiki.js to use a jquery ajax call to request and display createinline * Add listener on xwiki:dom:updated events in both create.js and select.js to properly load them in case of dom updates * Provide new translations for getting better information from the name strategy * Improve a bit the template for displaying errors * Fix page test * Fix page object * Move translations * Fix typos in translations * Fix since (cherry picked from commit 0d91409d)
Showing
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/main/resources/ApplicationResources.properties 5 additions, 1 deletion...on-api/src/main/resources/ApplicationResources.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources.properties 23 additions, 0 deletions...efault/src/main/resources/ApplicationResources.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_de.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_de.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_es.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_es.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_fr.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_fr.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ja.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_ja.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ko.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_ko.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_ru.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_ru.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-default/src/main/resources/ApplicationResources_uk.properties 23 additions, 0 deletions...ult/src/main/resources/ApplicationResources_uk.properties
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.de.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.de.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.es.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.es.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.fr.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.fr.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ja.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.ja.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ko.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.ko.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.ru.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.ru.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.uk.xml 0 additions, 2 deletions.../resources/XWiki/EntityNameValidation/Translations.uk.xml
- xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-ui/src/main/resources/XWiki/EntityNameValidation/Translations.xml 0 additions, 2 deletions...ain/resources/XWiki/EntityNameValidation/Translations.xml
- xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java 12 additions, 11 deletions...oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java
- xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateActionRequestHandler.java 29 additions, 12 deletions...in/java/com/xpn/xwiki/web/CreateActionRequestHandler.java
- xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java 2 additions, 1 deletion...-test-ui/src/main/java/org/xwiki/test/ui/po/ViewPage.java
Loading
Please register or sign in to comment