-
- Downloads
XWIKI-21571: Change default value of the reset password token lifetime (#3012)
Change the mechanism of the reset password token to not reset it at each verification code check, but only when the password is actually reset, and when its lifetime expired. Also provide a mandatory document initializer for the ResetPasswordRequest xclass. Change a bit more the logic: if the token lifetime configuration is set to 0 (which was the default) then we automatically remove the reset password request xobject at first wrong attempt (bad verification code): it will prevent any bruteforce attack. Then if there's a token lifetime configuration set, we don't remove the xobject when a bad attempt is performed: user might have used the wrong mail for example. But we do remove the xobject when it's expired. And if it's expired, or if the code was wrong, in both cases we immediately return an error. Move ResetPasswordIT and ForgotUserNameIT from administration-test-docker to a new module security-authentication-test-docker since it's related to security-authentication module now. --------- Co-authored-by:Manuel Leduc <manuel.leduc@xwiki.com> (cherry picked from commit b410dad4)
Showing
- xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/pom.xml 0 additions, 10 deletions...on-test/xwiki-platform-administration-test-docker/pom.xml
- xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/AllIT.java 0 additions, 12 deletions...r/src/test/it/org/xwiki/administration/test/ui/AllIT.java
- xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/ResetPasswordRequestClass.xml 0 additions, 110 deletions...ui/src/main/resources/XWiki/ResetPasswordRequestClass.xml
- xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties 5 additions, 1 deletion...ldcore/src/main/resources/ApplicationResources.properties
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/pom.xml 8 additions, 0 deletions...m-security/xwiki-platform-security-authentication/pom.xml
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/DefaultResetPasswordManager.java 119 additions, 89 deletions.../authentication/internal/DefaultResetPasswordManager.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/DefaultResetPasswordRequestResponse.java 5 additions, 0 deletions...ication/internal/DefaultResetPasswordRequestResponse.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/ResetPasswordRequestClassDocumentInitializer.java 75 additions, 0 deletions...nternal/ResetPasswordRequestClassDocumentInitializer.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/resources/ApplicationResources.properties 3 additions, 2 deletions...efault/src/main/resources/ApplicationResources.properties
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/resources/META-INF/components.txt 1 addition, 0 deletions...cation-default/src/main/resources/META-INF/components.txt
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultResetPasswordManagerTest.java 120 additions, 44 deletions...hentication/internal/DefaultResetPasswordManagerTest.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/java/org/xwiki/security/authentication/script/AuthenticationScriptService.java 2 additions, 3 deletions...ty/authentication/script/AuthenticationScriptService.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-test/pom.xml 48 additions, 0 deletions...ation/xwiki-platform-security-authentication-test/pom.xml
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-test/xwiki-platform-security-authentication-test-docker/pom.xml 137 additions, 0 deletions...wiki-platform-security-authentication-test-docker/pom.xml
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-test/xwiki-platform-security-authentication-test-docker/src/test/it/org/xwiki/security/authentication/test/ui/AllIT.java 46 additions, 0 deletions...t/it/org/xwiki/security/authentication/test/ui/AllIT.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-test/xwiki-platform-security-authentication-test-docker/src/test/it/org/xwiki/security/authentication/test/ui/ForgotUsernameIT.java 2 additions, 1 deletion...iki/security/authentication/test/ui/ForgotUsernameIT.java
- xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-test/xwiki-platform-security-authentication-test-docker/src/test/it/org/xwiki/security/authentication/test/ui/ResetPasswordIT.java 7 additions, 12 deletions...wiki/security/authentication/test/ui/ResetPasswordIT.java
- xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm 6 additions, 7 deletions...guration-resources/src/main/resources/xwiki.properties.vm
Loading
Please register or sign in to comment