XWIKI-20824: Administration user images must have an alternate text (#2167)

* Added an alt text to user avatars.

Note: The change to solve the PR is in getusers.vm, but other files were changed too to solve the same problem. The solution is the same since the structure around those images is the same. Removed the value for the alt in SolR search, because this would cause a repeated text when reading through the document. See JIRA for the reason why this value should be empty.

xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/attachment_macros.vm

@@ -163,7 +163,7 @@
   <div class="user" data-reference="$escapetool.xml($userName)">
     <span class="user-avatar-wrapper">
       #getUserAvatarURL($userName $avatarURL 120)
-      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" />
+      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="" />
     </span>
     $xwiki.getUserName($userName)
   </div>
@@ -279,4 +279,4 @@
 }}$jsontool.serialize($liveDataConfig){{/liveData}}
 
 {{html clean="false"}}#deleteAttachmentModal(){{/html}}
-#end
+#end
\ No newline at end of file

xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/main/resources/templates/likers.vm

@@ -22,7 +22,7 @@
     <div class="user#if ($disabled) disabled#end" data-reference="$escapetool.xml($userReference)">
     <span class="user-avatar-wrapper">
       #getUserAvatarURL($userReference $avatarURL 120)
-      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" />
+      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="" />
     </span>
       <a href="$xwiki.getURL($userReference)">$escapetool.xml($userReference.name)</a>
     </div>
@@ -119,4 +119,4 @@
     })
 
     #livetable("likers" $columns $columnsProperties $options)
-#end
+#end
\ No newline at end of file

xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-ui/src/main/resources/Main/SolrUserFacet.xml

@@ -42,7 +42,7 @@
   #set ($escapedUserName = $escapetool.xml($xwiki.getPlainUserName($userReference)))
   #getUserAvatarURL($userReference $avatarURL 30)
   <span class="user">##
-    <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="$escapedUserName" />##
+    <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="" />##
     <span class="user-name">$escapedUserName</span>##
   </span>##
 #end

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/getusers.vm

@@ -21,7 +21,7 @@
   <div class="user#if ($disabled) disabled#end" data-reference="$escapetool.xml($userReference)">
     <span class="user-avatar-wrapper">
       #getUserAvatarURL($userReference $avatarURL 120)
-      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" />
+      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="" />
     </span>
     <a href="$xwiki.getURL($userReference)">$escapetool.xml($userReference.name)</a>
   </div>

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/macros.vm

@@ -2934,7 +2934,7 @@ Recursive title display detected!##
   <div class="user" data-reference="$escapetool.xml($docReference)">
     <span class="user-avatar-wrapper">
       #getUserAvatarURL($docReference $avatarURL 120)
-      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" />
+      <img class="user-avatar" src="$escapetool.xml($avatarURL.url)" alt="" />
     </span>
     <a href="$xwiki.getURL($docReference)">$escapetool.xml($docReference.name)</a>
   </div>
@@ -3031,4 +3031,4 @@ Recursive title display detected!##
  *#
 #macro (unwrapXPropertyDisplay $displayOutput)
 $!stringtool.removeEnd($stringtool.removeStart($displayOutput, '{{html clean="false" wiki="false"}}'), '{{/html}}')##
-#end
+#end
\ No newline at end of file