XWIKI-11745: Fail the build when unit test output content to stdout or stderr

xwiki-platform-core/pom.xml

@@ -311,7 +311,21 @@
                 <value>${basedir}/target/screenshots</value>
               </property>
             </systemProperties>
+            <!-- Verify that unit tests don't output anything to stdout/stderr -->
+            <properties>
+              <property>
+                <name>listener</name>
+                <value>org.xwiki.test.CaptureConsoleRunListener</value>
+              </property>
+            </properties>
           </configuration>
+          <dependencies>
+            <dependency>
+              <groupId>org.xwiki.commons</groupId>
+              <artifactId>xwiki-commons-tool-test-simple</artifactId>
+              <version>${project.version}</version>
+            </dependency>
+          </dependencies>
         </plugin>
         <plugin>
           <groupId>com.atlassian.maven.plugins</groupId>

xwiki-platform-core/xwiki-platform-annotations/xwiki-platform-annotation-core/pom.xml

@@ -115,6 +115,14 @@
           </execution>
         </executions>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-annotations/xwiki-platform-annotation-maintainer/pom.xml

@@ -107,6 +107,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-application-manager/xwiki-platform-application-manager-api/pom.xml

@@ -71,6 +71,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-cache/xwiki-platform-cache-oscache/pom.xml

@@ -85,6 +85,14 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/pom.xml

@@ -91,6 +91,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-configuration/xwiki-platform-configuration-default/pom.xml

@@ -99,6 +99,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>
\ No newline at end of file

xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/pom.xml

@@ -99,6 +99,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-macro/pom.xml

@@ -144,6 +144,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/pom.xml

@@ -77,7 +77,6 @@
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-compress</artifactId>
     </dependency>
-
     <!-- Test dependencies -->
     <dependency>
       <groupId>org.xwiki.platform</groupId>
@@ -98,7 +97,6 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
-
   <build>
     <plugins>
       <plugin>
@@ -137,6 +135,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/pom.xml

@@ -96,6 +96,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-instance/xwiki-platform-filter-instance-oldcore/pom.xml

@@ -109,6 +109,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/pom.xml

@@ -178,6 +178,8 @@
           <classpathDependencyExcludes>
             <classpathDependencyExcludes>org.xwiki.platform:xwiki-platform-oldcore:jar</classpathDependencyExcludes>
           </classpathDependencyExcludes>
+          <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+          <properties combine.self="override"/>
         </configuration>
       </plugin>
     </plugins>

xwiki-platform-core/xwiki-platform-messagestream/xwiki-platform-messagestream-api/pom.xml

@@ -65,4 +65,16 @@
       <artifactId>slf4j-api</artifactId>
     </dependency>
   </dependencies>
+  <build>
+    <plugins>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 </project>

xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/pom.xml

@@ -102,6 +102,14 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-oldcore/pom.xml

@@ -644,9 +644,13 @@
   </dependencies>
   <build>
     <plugins>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
       </plugin>
       <!-- Publish a Core Test JAR -->
       <plugin>

xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/pom.xml

@@ -46,4 +46,16 @@
       <artifactId>commons-collections</artifactId>
     </dependency>
   </dependencies>
+  <build>
+    <plugins>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 </project>

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/pom.xml

@@ -112,6 +112,14 @@
           </excludes>
         </configuration>
       </plugin>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-php/pom.xml

@@ -48,13 +48,11 @@
       <artifactId>resin-quercus</artifactId>
       <version>3.2.1</version>
     </dependency>
-
     <!-- Quercus needs the servlet API to properly initialize -->
     <dependency>
       <groupId>javax.servlet</groupId>
       <artifactId>servlet-api</artifactId>
     </dependency>
-
     <!-- Testing dependencies -->
     <dependency>
       <groupId>org.xwiki.platform</groupId>
@@ -70,4 +68,16 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
+  <build>
+    <plugins>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 </project>

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-useravatar/pom.xml

@@ -42,4 +42,16 @@
       <version>${project.version}</version>
     </dependency>
   </dependencies>
+  <build>
+    <plugins>
+      <!-- TODO: Remove once the tests have been fixed to not output anything to the console! -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <properties combine.self="override"/>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 </project>