[Misc] Fix EditIT#editwithConflict by removing bad hack in BaseModal

(cherry picked from commit 89a734fc)

xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-pageobjects/src/main/java/org/xwiki/ckeditor/test/po/image/ImageDialogSelectModal.java

@@ -44,8 +44,6 @@ public ImageDialogSelectModal()
 
     private ImageDialogSelectModal(By selector)
     {
-        super(selector);
-
         // This modal is added on demand so we can't rely on the base constructor to remove the "fade in" effect. We
         // have to do the wait ourselves.
         getDriver().waitUntilElementIsVisible(selector);

xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BaseModal.java

@@ -36,20 +36,23 @@ public class BaseModal extends BaseElement
 {
     protected WebElement container;
 
+    /**
+     * Default constructor when we want to manually set the container. This should be used with caution.
+     */
+    protected BaseModal()
+    {
+    }
+
     // This constructor remove the fade effect, but it only takes effect before the modal is opened
     // so take care to create the modal before doing the action to open it.
     public BaseModal(By selector)
     {
-        List<WebElement> containers = getDriver().findElementsWithoutWaiting(selector);
-        if (!containers.isEmpty()) {
-            // The modal is present and most probably hidden.
-            this.container = containers.get(0);
-            // The fade effect is deleted from the modal because there isn't an easy way for waiting on the modal to be
-            // shown. This "fade in" effect is also not necessary for the test.
-            String className = this.container.getAttribute("class");
-            className = className.replace("fade", "");
-            getDriver().executeScript("arguments[0].setAttribute(\"class\",arguments[1])", this.container, className);
-        }
+        this.container = getDriver().findElement(selector);
+        // The fade effect is deleted from the modal because there isn't an easy way for waiting on the modal to be
+        // shown. This fade in effect is also not necessary for the test.
+        String className = this.container.getAttribute("class");
+        className = className.replace("fade", "");
+        getDriver().executeScript("arguments[0].setAttribute(\"class\",arguments[1])", this.container, className);
     }
 
     public String getTitle()