Unverified Commit dfba8556 authored 9 months ago by Simon Urli Committed by GitHub 9 months ago

XWIKI-22211: Deprecate NotificationFilterPreferenceProvider (#2882)

  * Deprecate and legacify NotificationFilterPreferenceProvider and
    NotificationFilterPreference#getProviderHint
  * Clean up all code relying on it simplifying a lot the implem of
    NotificationFilterPreference
  * Only valid usage of the providerHint was for checking if a filter
    preference was stored or not: replaced it with checking the ID of
the filter
  * Fix bad prefix in filters internal ids
  * Fix typos

parent 8677475e

No related branches found

No related tags found

No related merge requests found

Hide whitespace changes

Inline Side-by-side

Showing

xwiki-platform-core/pom.xml 12 additions, 0 deletions

xwiki-platform-core/pom.xml
xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-filters/xwiki-platform-legacy-notifications-filters-api/pom.xml 133 additions, 1 deletion

...s/xwiki-platform-legacy-notifications-filters-api/pom.xml
xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-filters/xwiki-platform-legacy-notifications-filters-api/src/main/aspect/org/xwiki/notifications/filters/NotificationFilterPreferenceCompatibilityAspect.aj 31 additions, 0 deletions

...ilters/NotificationFilterPreferenceCompatibilityAspect.aj
xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-filters/xwiki-platform-legacy-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/CompatibilityNotificationFilterPreference.java 39 additions, 0 deletions

...ns/filters/CompatibilityNotificationFilterPreference.java
xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-filters/xwiki-platform-legacy-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/NotificationFilterPreferenceProvider.java 5 additions, 3 deletions

...cations/filters/NotificationFilterPreferenceProvider.java
xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-sources/src/test/java/org/xwiki/notifications/sources/internal/LegacyDefaultNotificationParametersFactoryTest.java 0 additions, 1 deletion

...ernal/LegacyDefaultNotificationParametersFactoryTest.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/pom.xml 2 additions, 0 deletions

...-filters/xwiki-platform-notifications-filters-api/pom.xml
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/NotificationFilterPreference.java 8 additions, 5 deletions

...i/notifications/filters/NotificationFilterPreference.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/NotificationFilterPreferenceManager.java 2 additions, 1 deletion

...ications/filters/NotificationFilterPreferenceManager.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManager.java 27 additions, 170 deletions

.../internal/DefaultNotificationFilterPreferenceManager.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/UserProfileNotificationFilterPreferenceProvider.java 0 additions, 116 deletions

...rnal/UserProfileNotificationFilterPreferenceProvider.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterExpressionGenerator.java 5 additions, 8 deletions

...nal/scope/ScopeNotificationFilterExpressionGenerator.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterPreference.java 0 additions, 6 deletions

...ers/internal/scope/ScopeNotificationFilterPreference.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/resources/META-INF/components.txt 0 additions, 1 deletion

...ns-filters-api/src/main/resources/META-INF/components.txt
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManagerTest.java 14 additions, 76 deletions

...ernal/DefaultNotificationFilterPreferenceManagerTest.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterTest.java 1 addition, 4 deletions

...s/filters/internal/scope/ScopeNotificationFilterTest.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreference.java 1 addition, 21 deletions

...filters/internal/DefaultNotificationFilterPreference.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/NotificationFilterPreferenceStore.java 8 additions, 16 deletions

...s/filters/internal/NotificationFilterPreferenceStore.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/UserAddedEventListener.java 0 additions, 1 deletion

...otifications/filters/internal/UserAddedEventListener.java
xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/migrators/NotificationFilterPreferencesMigrator.java 0 additions, 1 deletion

...rnal/migrators/NotificationFilterPreferencesMigrator.java

with 288 additions and 431 deletions

Please register or to comment