XWIKI-20092: Enable the lightbox view for images by default (#1918)

xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-test/xwiki-platform-image-lightbox-test-docker/src/test/it/org/xwiki/image/lightbox/test/ui/LightboxIT.java

@@ -46,15 +46,17 @@
 
 /**
  * Functional tests for the image lightbox.
- * 
+ *
  * @version $Id$
  * @since 14.1RC1
  */
 @UITest(properties = {
     // Add the FileUploadPlugin which is needed by the test to upload attachment files
-    "xwikiCfgPlugins=com.xpn.xwiki.plugin.fileupload.FileUploadPlugin"})
+    "xwikiCfgPlugins=com.xpn.xwiki.plugin.fileupload.FileUploadPlugin" })
 class LightboxIT
 {
+    private static final String USER_NAME = "JohnDoe";
+
     private static final DocumentReference LIGHTBOX_CONFIGURATION_REFERENCE =
         new DocumentReference("xwiki", Arrays.asList("XWiki", "Lightbox"), "LightboxConfiguration");
 
@@ -62,8 +64,6 @@ class LightboxIT
 
     private static final List<String> IMAGES = Arrays.asList("image1.png", "image2.png", "missingImage.png");
 
-    public static final String USER_NAME = "JohnDoe";
-
     @BeforeAll
     void beforeAll(TestUtils testUtils)
     {

xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-ui/src/main/resources/XWiki/Lightbox/LightboxConfiguration.xml

@@ -312,7 +312,7 @@
       <validationScript/>
       <isLightboxEnabled>
         <customDisplay/>
-        <defaultValue>0</defaultValue>
+        <defaultValue>1</defaultValue>
         <disabled>0</disabled>
         <displayFormType>select</displayFormType>
         <displayType/>
@@ -327,7 +327,7 @@
       </isLightboxEnabled>
     </class>
     <property>
-      <isLightboxEnabled>0</isLightboxEnabled>
+      <isLightboxEnabled>1</isLightboxEnabled>
     </property>
   </object>
 </xwikidoc>

xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-ui/src/main/resources/XWiki/Lightbox/LightboxConfigurationClass.xml

@@ -48,7 +48,7 @@
     <validationScript/>
     <isLightboxEnabled>
       <customDisplay/>
-      <defaultValue>0</defaultValue>
+      <defaultValue>1</defaultValue>
       <disabled>0</disabled>
       <displayFormType>select</displayFormType>
       <displayType/>