Skip to content
Snippets Groups Projects
  1. Jun 05, 2023
  2. Jun 02, 2023
  3. Jun 01, 2023
  4. May 31, 2023
    • Vincent Massol's avatar
    • Sereza7's avatar
      XWIKI-20842: More actions button is an anchor (#2171) · d5bc04d3
      Sereza7 authored
      * Changed the type of the button element depending on its behaviour.
      * Updated selectors in environment tests.
      
      Note: We could also separate the button-anchor templates in two functions and/or use a boolean as a parameter rather than checking the presence of a value for a field. The current implementation aims at minimal refactoring.
      d5bc04d3
    • Simon Urli's avatar
      XWIKI-20919: The document is deleted when it has only one version if a... · c7275aa2
      Simon Urli authored
      XWIKI-20919: The document is deleted when it has only one version if a revision deletion action is triggered with a non-existing version (#2194)
      
        * Add checks in XWiki#deleteDocumentVersions and
          XWikiDocumentArchive#removeVersions to perform removal is the range
      of version is not empty and to avoid reseting the entire archive in such
      case
        * Perform some refactoring in XWikiDocumentArchive to document
          properly getNodes and make it more clear on the meaning of its
      arguments. Rename #getNearestFullVersion also since the name is wrong:
      that method does not return the nearest full version, it returns the
      next one
      
      Co-authored-by: default avatarManuel Leduc <manuel.leduc@xwiki.com>
      c7275aa2
    • Simon Urli's avatar
      XWIKI-17034: Allow to define different grouping strategy for notifications · 7d07e309
      Simon Urli authored
      This commit provides an important change in the design in order to fix a
      flaw of the previous solution: in previous solution the number of
      composite events obtained would never have matched the requested number
      of events wanted by the user. The requested number would have limited
      the number of individual events only.
      So in order to keep same UX for users, I implement here in
      DefaultParametrizedNotificationManager#getEvents the possibility to
      retrieve as many composite events as defined by the
      NotificationParameters#expectedCount.
      Then I also provide distinct caches to ensure to be able to cache either
      the composite events, or the events, and to distinguish their count.
      Finally I deprecate here the NotificationManager interface in favor of
      the ParametrizedNotificationManager which is far more simple to use, and
      better to maintain on the long run.
      7d07e309
    • Simon Urli's avatar
      XWIKI-17034: Allow to define different grouping strategy for notifications · bef57740
      Simon Urli authored
      The purpose of this commit is to start providing the full architecture
      for having different strategies for grouping notifications depending on
      users' choices and on the kind of output target (e.g. email, alert, rss,
      etc).
      This commit provides the new roles for defining a grouping strategy and
      for loading the strategy component depending on the user and the target.
      By default the grouping strategy is the one that was already existing
      and based on on the similarity algorithm. Another strategy is already
      provided only based on the type of events.
      There's still remaining questions to finish this work, like how to deal
      with the number of unread events (as it was before handled by
      considering the composite events).
      There's also work to do to handle the wiki notification settings for
      this, and for presenting the different options to the users.
      Finally we probably need to rework the templates so that they would work
      with the strategies, or they could take into account the strategies for
      the display (e.g. a template per strategy).
      bef57740
    • Thomas Mortagne's avatar
      8dd74928
    • Simon Urli's avatar
      XWIKI-19070: Change the notifications locations inclusion default: don't... · 7a07f04d
      Simon Urli authored
      XWIKI-19070: Change the notifications locations inclusion default: don't consider that the whole wiki is watched when nothing is watched
      
      This commits provide the modification that have been voted to change the
      standard behaviour of watched pages for new users.
      
      The following behaviour are changed:
        1. by default, nothing is watched until the user decided to watch
           something
        2. by default, all events type are enabled until an admin explicitely
           switched off some event types, or the user does
        3. directly following 1 and 2, no event type is magically enabled anymore
           whenever a user creates a page with autowatch enabled
      
      Technically (3) means that we don't need anymore XWikiEventTypesEnabler
      component so I get rid of it. (1) means that the default value in
      DefaultWatchedEntitiesManager needed to be changed as well as the way to
      compute it in the script service: no preferences means no watch.
      (2) is the one involving most of the changes: I needed to ensure that
      default value for preferences is enabled, and to also ensure that
      whenever the list of preferences is empty it means that everything is
      enabled, which impacts directly UserEventManager to dispatch the events.
      (2) also means that we don't need the
      NotificationAdministrationDocumentInitializer for Mention anymore, as by
      default this event type is now enabled, as well as all the other ones.
      
      I updated the integration tests according to the changes.
      
      Note that those changes don't involve any migration: existing users that
      already have preferences should still use their preferences. The
      behavioural change only applies to new users without any preferences
      (including without any preferences set at administration level).
      7a07f04d
    • Sereza7's avatar
      XWIKI-20825: Edit autosave frequency contrast issue (#2170) · ec20f549
      Sereza7 authored
      * Removed the use of opacity
      * Added a new class to the parent element instead.
      * Updated style using theme for the new class.
      ec20f549
    • Sereza7's avatar
      XWIKI-20791: WCAG reporting doesn't give enough information in logs (#2116) · 52f4ccf1
      Sereza7 authored
      * Added a report for the nature of the violations in WCAG warnings and errors.
      * Fixed an imprecision when counting violations. The violation count now depends on the number of violated nodes for a rule, instead of being 1 for each rule broken in a validation. This is finer grained and holds more meaning than the previously computed counts. This results in an increase of the numbers displayed, even though the reports are the same and no additional violations are found.
      * Changed all the uses of `Amount` to `Count`
      * Factorized code
      * Changed logging level of the test-suite total timing from DEBUG to INFO
      52f4ccf1
    • Sereza7's avatar
      XWIKI-20733: Top navigation search section has two tab indexes (#2193) · b5bd6b0a
      Sereza7 authored
      * Updated the implementation of the button 'disabled' state as hidden inputs cannot have placeholders or labels, this also caused webstandards test failures.
      b5bd6b0a
  5. May 30, 2023
  6. May 29, 2023
  7. May 28, 2023
  8. May 26, 2023
    • Sereza7's avatar
      XWIKI-20824: Administration user images must have an alternate text (#2167) · a7e61069
      Sereza7 authored
      * Added an alt text to user avatars.
      
      Note: The change to solve the PR is in getusers.vm, but other files were changed too to solve the same problem. The solution is the same since the structure around those images is the same. Removed the value for the alt in SolR search, because this would cause a repeated text when reading through the document. See JIRA for the reason why this value should be empty.
      a7e61069
    • Simon Urli's avatar
      XWIKI-20939: Impossible to solve conflict with custom resolution when content... · e62cb754
      Simon Urli authored
      XWIKI-20939: Impossible to solve conflict with custom resolution when content and object are involved
      
        * Provide an API to check if the conflicts only concerns the content
        * Use that API in previewdiff to display or not the custom resolution
          choice
      e62cb754
Loading