* Cache failures
* Properly dispose the caches
* Only send requests to trusted domains
* Only embed actual images
* Limit responses to 1MB
* Introduce configuration options for timeout, maximum size and if the
  feature is enabled at all
* Add a UI test that checks that attachment embedding is working in
  general
* Move to httpclient5
* Expose the cookie domains configuration in AuthenticationConfiguration

(cherry picked from commit bff0203e)

* Add separate page objects for raw and rendered diff tabs
* Return only a raw changes page object for the extension conflict as it
  doesn't display the full diff UI

(cherry picked from commit 18c079fc)

(cherry picked from commit 6f2e8886)

  * Add missing dependency of extension-index that contains a migration
    for creating the flavor data

(cherry picked from commit 89129421)

(cherry picked from commit 9715fe93)

This moves the drag&drop code from ApplicationsPanelAdministrationPage
into a dedicated SortableElement. This code is then used in
StaticListItemsEditor to handle drag&drop for list items in the hope of
resolving flickers related to this.

(cherry picked from commit 1a294a25)

This is an attempt at fixing flickering in
WithoutScriptRightIT#createApplicationWithoutScriptRight which seems to
be caused by drag&drop operations starting before the class editor page
has been fully loaded.

(cherry picked from commit 2ec6cb6f)

(cherry picked from commit 89a734fc)

(cherry picked from commit 93b8ec70)

* Added a gap in between the login form submit button and the recovery anchors

Note: I made this gap 1em large, but this is completely arbitrary.
(cherry picked from commit 96429d15)

  * Stop making the test failing until this is fixed

(cherry picked from commit fbee9e28)

XWIKI-21078: Missing CSRF token causes warning that the content will be executed in restricted mode to be displayed when creating an XClass

  * Provide CSRF token to create a new class

(cherry picked from commit aa73ad7a)

Fix flicker when setting an image external url

XWIKI-21136: On upgrade, the old version of an extension is not marked as not installed on solr (#2251)

Sereza7 authored 1 year ago and Simon Urli committed 1 year ago

* Now using  `#0` instead of `null` for an empty URL
* (extra Accessibility) Updated the DOM to properly generate the suggest element
* (extra Accessibility) Updated style to avoid visual changes related to the DOM changes
* (Functionality of suggests) Added `SPACE` as an entry validation key
* Replaced the empty anchor with a `javascript:void()`

Note: avoids changing the URL of the current page.

Co-authored-by: Marius Dumitru Florea <marius@xwiki.com>
(cherry picked from commit 78728c97)

Fix missing test adaptation after cherry-picking.

XWIKI-21133: User reference serializer doesn't serialize the current user reference when the current user is superadmin

* Change the code to use the same logic for the current user and an
  explicitly given user.
* Add a test.

(cherry picked from commit ad789c87)

XWIKI-21082: Unable to login after setting a new password with non-ascii characters via password reset

* Move the encoding and request restorer filter before the routing
  filter.
* Adapt the ResetPasswordIT to test with a non-ascii character.

(cherry picked from commit ecd55206)

(cherry picked from commit 5eb1d4de)

(cherry picked from commit fec8e0e5)

* Use CopyOnWriteArrayList for VALUES (writes to this list are rare).

(cherry picked from commit a4c0ab63)

(cherry picked from commit 0b0ad8f2)

(cherry picked from commit 04e325d5)

* Try to fix flickering test (the page leave confirmation from the UndoRedoIT blocks QuickActionsIT)

(cherry picked from commit d8c43661)

* We need to call lockSnapshot before inserting / removing the placeholder in order to avoid creating a separate entry in the Undo history
XWIKI-21094: The empty line placeholder ends up in the wiki syntax when switching to Source
* We need to filter the placeholder even when the editing area is read-only, which happens right before switching to Source

Also:
* Overwrite the AutoComplete to save the query in an HTML attribute that we can check from functional tests in order to avoid flickers.
* Refactor test page objects and update tests so they pass in both Firefox and Chrome

(cherry picked from commit b0a6afff)

* Apply workaround until Paged.js issue is fixed ( https://github.com/pagedjs/pagedjs/issues/45 )

(cherry picked from commit e995f4c4)

(cherry picked from commit 241d8e08)

(cherry picked from commit c5025ef4)

* Fix since version and remove whitespace.

(cherry picked from commit 95aeed38)